Bug fixes for 0.20.0 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MAPPlugin class was originally created to mimic the WorkflowStepMountPoint which would allow us to use the existing addStep function to add "plugin-like" objects to the Plugin Finder GUI. Since there have been updates to the WorkflowStepMountPoint and the addStep method since the PR was submitted, these changes are required to maintain the existing functionality. Obviously this current implementation isn't very robust. When I get a chance I will look at updating the way the Plugin Finder populates the QListView so that it doesn't rely on the addStep method.
hsorby
reviewed
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses bugs related to the Plugin Finder tool introduced in this PR.
Since the original PR was submitted prior to the migration to PySide6, I have had to make some changes to the tool to upgrade it from PySide2.
Some changes have also been made to the
MAPPluginclass utilised by the Plugin Finder tool. TheMAPPluginclass was originally created to mimic theWorkflowStepMountPoint, which would allow us to use the existingaddStepfunction to add "plugin-like" objects to the Plugin Finder GUI. Since there have been updates to theWorkflowStepMountPointand theaddStepmethod since the PR was submitted, changes are now required to maintain the existing functionality. Obviously this current implementation isn't very robust. When I get a chance I will look at updating the way the Plugin Finder populates theQListViewso that it doesn't rely on theaddStepmethod.