Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube videos do not display when [autoheight]="true" is used #574

Closed
ChrisMBarr opened this issue Aug 22, 2023 · 2 comments
Closed

Youtube videos do not display when [autoheight]="true" is used #574

ChrisMBarr opened this issue Aug 22, 2023 · 2 comments
Labels

Comments

@ChrisMBarr
Copy link
Contributor

ChrisMBarr commented Aug 22, 2023

What is the expected behavior?

Youtube videos should display

What is the current behavior?

Youtube videos do not display at all when [autoheight]="true" is used. Just a blank space where the video would be. Removing autoheight will make it display.

What are the steps to reproduce?

itemsArr= [
	new YoutubeItem({src: `1Ovcl3FYL3Y`}),
]
<gallery [items]="itemsArr" [autoHeight]="true" />

StackBlitz Demo

What is the use-case or motivation for changing an existing behavior?

To make it work with videos

Which versions are you using for the following packages?

Angular: 16.2.1
Angular CDK: 16.2.1
Angular CLI: 16.2.0
Typescript: 5.1.6
Gallery: 11.0.0

Is there anything else we should know?

There are exactly zero demos of video content being used. The wiki page for mixed content usage makes mention of this feature in code, but there is no actual live demo. There is a link at the bottom of that page to "see advanced demo" which points to https://ngx-gallery.netlify.app/#/advanced which is a 404 error. There are a few wiki pages that link to this advanced example that no longer exists

@MurhafSousli
Copy link
Owner

MurhafSousli commented Aug 23, 2023

Thanks for bringing this up, I fixed the link of that page, it is https://ngx-gallery.netlify.app/#/custom-templates

@MurhafSousli
Copy link
Owner

MurhafSousli commented Dec 23, 2023

This is fixed v12 beta npm i ng-gallery@beta, closed in #583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants