Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbox typings aren't aligned with CDK overlay #541

Closed
Harpush opened this issue Apr 22, 2023 · 1 comment · Fixed by #542
Closed

Lightbox typings aren't aligned with CDK overlay #541

Harpush opened this issue Apr 22, 2023 · 1 comment · Fixed by #542
Labels
enhancement

Comments

@Harpush
Copy link

Harpush commented Apr 22, 2023

What is the expected behavior?

For example panelClass in CDK overlay accepts string or string[] while you accept only string.

What is the current behavior?

Less API type options than CDK

What are the steps to reproduce?

None...

What is the use-case or motivation for changing an existing behavior?

Allowing more control which is already implemented in types

Which versions are you using for the following packages?

Latest

Is there anything else we should know?

Not only panel class but other properties too.
MurhafSousli added a commit that referenced this issue Apr 23, 2023
@MurhafSousli
enhance(lightbox): Allow multiple classes on panelClass config, clo…
0abc6bd 
…eses #541
@MurhafSousli MurhafSousli linked a pull request Apr 23, 2023 that will close this issue
Release/8.0.4 #542
Merged
@Harpush
Copy link
Author

Harpush commented Apr 25, 2023

@MurhafSousli adding that:
backdropClass - can be string[] too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release/8.0.4 MurhafSousli/ngx-gallery
2 participants
@MurhafSousli @Harpush