Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos are unplayable if type not specified #515

Closed
molnarm opened this issue Jan 12, 2023 · 1 comment · Fixed by #516
Closed

Videos are unplayable if type not specified #515

molnarm opened this issue Jan 12, 2023 · 1 comment · Fixed by #516
Labels

Comments

@molnarm
Copy link

molnarm commented Jan 12, 2023

What is the expected behavior?

Video items where the type (video format) is not specified should be played correctly.

What is the current behavior?

The video is not recognized by the browser as playable.

What are the steps to reproduce?

Create a VideoItem with src set to either a simple string, or an array where one of the items has no type specified.

The rendered video tag will still always have type="undefined" on its source tag, so the browser is unable to play it. Same for using null. The only workaround I found is explicitly setting empty string as type, then the empty attribute is ignored by the browser.

StackBlitz: https://stackblitz.com/edit/ngx-gallery-fnassi?file=src/app/home/home.component.ts
Note how the only video to properly load and play is the third item.

Which versions are you using for the following packages?

Angular: 15.1.0
Angular CDK: 15.0.4
Angular CLI: 15.0.5
Typescript: 4.8.4
Gallery: 8.0.1

@molnarm molnarm changed the title Video type is output even if not set Videos are unplayable if type not specified Jan 12, 2023
MurhafSousli added a commit that referenced this issue Jan 17, 2023
…f-type-not-specified

fix(core): Videos are unplayable if type not specified, closes #515
@MurhafSousli
Copy link
Owner

Fixed in v8.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants