Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close icon in lightbox container being rerendered all the time due to bug in template #307

Closed
daelmaak opened this issue Nov 15, 2019 · 0 comments · Fixed by #472
Closed
Labels

Comments

@daelmaak
Copy link

What is the expected behavior?

Close icon doesn't get rerendered all the time so that it can be clicked.

What is the current behavior?

Due to [innerHTML]="sanitizer.bypassSecurityTrustHtml(closeIcon)" in the lightbox.component.ts, if change detection runs often enough, it causes the close icon to be rerendered all the time and prevents it effectively from being clicked -> the lightbox doesn't get closed.

What are the steps to reproduce?

https://stackblitz.com/edit/ngx-gallery-imageviewer-k2e3qu

  1. Open the full screen lightbox
  2. Try to close it with the cross close-icon
  3. It doesn't get closed

Which versions are you using for the following packages?

Angular: 8.2.11
Angular CDK: 8.2.3
Angular CLI: 8.3.9
Typescript: 3.4.5
Gallery: 4.0.3

@MurhafSousli MurhafSousli linked a pull request Oct 3, 2022 that will close this issue
MurhafSousli added a commit that referenced this issue Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants