Make end portal generation drop blocks and refactor code #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwoo1110
reviewed
Aug 23, 2024
src/main/java/com/onarandombox/MultiverseNetherPortals/listeners/MVNPEntityListener.java
Outdated
Show resolved
Hide resolved
src/main/java/com/onarandombox/MultiverseNetherPortals/utils/EndPlatformCreator.java
Show resolved
Hide resolved
src/main/java/com/onarandombox/MultiverseNetherPortals/utils/EndPlatformCreator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/onarandombox/MultiverseNetherPortals/listeners/MVNPEntityListener.java
Outdated
Show resolved
Hide resolved
|
|
Ohhhhh hm, but should be make it configurable? Like what if I'm on 1.19 and I don't want the 1.21 behaviour |
|
Valid, a new config option like "end_platform_drop_blocks"? |
benwoo1110
approved these changes
Aug 25, 2024
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #266
Aligns behaviour of that introduced in 1.21, also some code refactoring was done