Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W-16235578: Added emebdding store munit tests #36

Merged
merged 6 commits into from
Aug 22, 2024
Merged

W-16235578: Added emebdding store munit tests #36

merged 6 commits into from
Aug 22, 2024

Conversation

arpitg-1
Copy link
Contributor

@arpitg-1 arpitg-1 commented Aug 21, 2024 •
edited
Loading

Updates

  • Added 2 emebdding store tests, one for creation of emebdding store and other for adding document to the store.
  • Updated jacoco version to the latest version as 0.8.6 is not compatible with java 17.
  • Updated @content to the required parameters, made similar changes to the demo folder.

dipeshkumardutta-sfemu
dipeshkumardutta-sfemu reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@dipeshkumardutta-sfemu dipeshkumardutta-sfemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpitg-1 arpitg-1 merged commit ce08053 into develop Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipeshkumardutta-sfemu dipeshkumardutta-sfemu dipeshkumardutta-sfemu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arpitg-1 @dipeshkumardutta-sfemu