Fix unicodeArray (SwifterSwift#544)

MtAden · Aug 14, 2018 · fb19497 · fb19497
1 parent 6f2c9fb
commit fb19497
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -57,6 +57,7 @@ The changelog for **SwifterSwift**. Also see the [releases](https://github.com/S
 - Fixed `scaled(toWidth:, with orientation:)` and `scaled(toHeight:, with orientation:)` were using image's scale as the scale factor. [#515](https://github.com/SwifterSwift/SwifterSwift/pull/515) by [VincentSit](https://github.com/VincentSit).
 - **String**:
   - Used [RFC 5322](http://emailregex.com/) in `isValidEmail`, an email address regex that 99.99% works. [#517](https://github.com/SwifterSwift/SwifterSwift/pull/517) by [Omar Albeik](https://github.com/omaralbeik)
+  - Fixed `unicodeArray()` not returning the correct unicode value due to Swift 4.2 new hashing system. [#544](https://github.com/SwifterSwift/SwifterSwift/pull/544) by [Omar Albeik](https://github.com/omaralbeik)
 
 ### Deprecated
 - **String**:

diff --git a/Sources/Extensions/SwiftStdlib/StringExtensions.swift b/Sources/Extensions/SwiftStdlib/StringExtensions.swift
@@ -499,11 +499,11 @@ public extension String {
 
 	/// SwifterSwift: Array with unicodes for all characters in a string.
 	///
-	///		"SwifterSwift".unicodeArray -> [83, 119, 105, 102, 116, 101, 114, 83, 119, 105, 102, 116]
+	///		"SwifterSwift".unicodeArray() -> [83, 119, 105, 102, 116, 101, 114, 83, 119, 105, 102, 116]
 	///
 	/// - Returns: The unicodes for all characters in a string.
 	public func unicodeArray() -> [Int] {
-		return unicodeScalars.map { $0.hashValue }
+		return unicodeScalars.map { Int($0.value) }
 	}
 
 	#if canImport(Foundation)