feat: add NGRX_UPDATE_ON_TYPE type to library exports #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MrWolfZ, thanks for the beautiful library. Just a suggestion on the above type is it possible to export the NGRX_UPDATE_ON_TYPE as type instead of enum this will help the template to recognize the type while setting the value like ngrxUpdateOn="blur", currently the IDE sees this as unrecognized type. By converting this from enum to type user will be able to correctly set the values during development as well. I will be ready to create a PR for this changes, let me know your thoughts on the same? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced with a case where I need to programmatically set the
ngrxUpdateOnvalue from a directive. Therefore It would be great to have an access toNGRX_UPDATE_ON_TYPEso I wouldn't need to have a crappy code like.ngrxUpdateOn = 'blur' as any.I hope this might be relevant for others too.