fix: allow enabling empty disabled array states

MrWolfZ · May 30, 2019 · 8a33d12 · 8a33d12
1 parent ca93697
commit 8a33d12
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/array/reducer/enable.spec.ts b/src/array/reducer/enable.spec.ts
@@ -1,4 +1,5 @@
 import { EnableAction } from '../../actions';
+import { createFormArrayState } from '../../state';
 import { enableReducer } from './enable';
 import {
   FORM_CONTROL_ID,
@@ -49,4 +50,15 @@ describe(`form array ${enableReducer.name}`, () => {
     const resultState = enableReducer(state, new EnableAction(state.controls[0].id));
     expect(resultState).not.toBe(state);
   });
+
+  it('should enable an empty disabled state', () => {
+    const state = {
+      ...createFormArrayState<string>(FORM_CONTROL_ID, []),
+      isDisabled: true,
+      isEnabled: false,
+    };
+
+    const resultState = enableReducer(state, new EnableAction(FORM_CONTROL_ID));
+    expect(resultState.isEnabled).toBe(true);
+  });
 });
diff --git a/src/array/reducer/enable.ts b/src/array/reducer/enable.ts
@@ -16,7 +16,7 @@ export function enableReducer<TValue>(
 
   const controls = dispatchActionPerChild(state.controls, controlId => new EnableAction(controlId));
 
-  if (controls === state.controls) {
+  if (controls === state.controls && state.isEnabled) {
     return state;
   }