v3/7/4

CHANGELOG.md

@@ -1,3 +1,7 @@
+# 3.7.4
+
+- Some v10 compatibility improvements.
+
 # 3.7.3
 
 - Some small improvements to the campaign fallback UI to ensure that its obvious a campaign is still selected if the campaign list fails.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ddb-importer",
-  "version": "3.7.3",
+  "version": "3.7.4",
   "author": "MrPrimate",
   "description": "Foundry VTT module for integrating D&D Beyond content",
   "private": true,

src/parser/advancements/AdvancementHelper.js

@@ -13,17 +13,17 @@ export default class AdvancementHelper {
   }
 
 
-  getSkillChoicesFromOptions(feature, level) {
+  getSkillChoicesFromOptions(feature, level, proficiencyFeatures = []) {
     const skillsChosen = new Set();
     const skillChoices = new Set();
 
     const choiceDefinitions = this.ddbData.character.choices.choiceDefinitions;
 
     this.ddbData.character.choices[this.type].filter((choice) =>
       // check all features
-      ((feature === null && this._proficiencyFeatures.some((f) => f.id === choice.componentId && f.requiredLevel === level))
+      ((feature === null && proficiencyFeatures.some((f) => f.id === choice.componentId && f.requiredLevel === level))
       // check specific feature
-       || (feature.id === choice.componentId && feature.requiredLevel === level))
+       || (feature && feature.id === choice.componentId && feature.requiredLevel === level))
       && choice.subType === 1
       && choice.type === 2
     ).forEach((choice) => {

src/parser/classes/DDBClass.js

@@ -460,7 +460,7 @@ export default class DDBClass {
   _setLegacySkills() {
     if (!this.legacyMode) return;
 
-    const skills = this.advancementHelper.getSkillChoicesFromOptions(null, 1);
+    const skills = this.advancementHelper.getSkillChoicesFromOptions(null, 1, this._proficiencyFeatures);
 
     this.data.system.skills = {
       value: skills.chosen,

src/parser/race/DDBRace.js

@@ -369,6 +369,7 @@ export default class DDBRace {
 
 
   linkFeatures(ddbCharacter) {
+    if (this.legacyMode) return;
     logger.debug("Linking Advancements to Feats for Race", {
       DDBRace: this,
       ddbCharacter,