Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Configuration for animations/transitions #65

Closed
2 tasks done
jacksongoode opened this issue Oct 26, 2023 · 6 comments · Fixed by #69
Closed
2 tasks done

✨ Configuration for animations/transitions #65

jacksongoode opened this issue Oct 26, 2023 · 6 comments · Fixed by #69
Assignees
Labels

Comments

@jacksongoode
Copy link

Feature Request Description

Beautiful project!

I think it might be nice to have the ability to configure the speed/bounciness and toggle of the preview animations. Sometimes it's a little too much movement on the screen when quickly switching.

Screenshots

No response

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single feature request (multiple feature requests should be reported individually)
@MrKai77
Copy link
Owner

MrKai77 commented Oct 26, 2023

Thank you so much!
I too, have thought of this as well. However, the reason I haven't done this yet is that I don't want to make Loop's user interface a bit too overwhelming to any user.
At the moment, Loop's preview window animations are defined by their: stiffness and damping, but I expect new users (and probably lots of experienced users) will not know how to configure these two settings. How would you envision the user configuring this feature in Loop? Would a slider for duration make sense?
EDIT: fixed a funny typo

@jacksongoode
Copy link
Author

I think a toggle to disable the transitions between each preview shape would be a good first step. Sometimes I just want to see the final orientation of the shape I'm planning on snapping to, without the animations.

I suppose this could be a duration slider where far left is "0" (animations are off) and far right could be the default transition duration. I can't imagine anyone would want a slower transition :)

@MrKai77
Copy link
Owner

MrKai77 commented Oct 27, 2023

Awesome, got it!
Will try and get this done within the next few days!

@MrKai77
Copy link
Owner

MrKai77 commented Oct 27, 2023

Ok... got this done in much less time than a "few days"!
Here's the latest build (it also contains the feature you wanted in #66): Loop.zip
You can find the animation setting in the preview window tab in the settings window. I also sped up the default animation duration. How does this look?
image

The only part that bothers me is that no one is likely to animate with a speed below 15-20ms, because at that point, it makes more sense to just have it instantly show the next position. I'm starting to think that this may work better if the user could select a animation duration from a picker (like how they select an icon), which has 3 options: Instant, Fast and Smooth, which then would adjust the animation duration for all of Loop's UI.
So, I'll try doing this and see how it goes!

MrKai77 added a commit that referenced this issue Oct 27, 2023
…tionstransitions`

# Conflicts:
#	Loop/Extensions/Defaults+Extensions.swift
@MrKai77
Copy link
Owner

MrKai77 commented Oct 27, 2023

Alright, I have implemented it and I'm pretty happy with how it turned out! Here's a screenshot of the setting:
image
EDIT: fixed another funny typo

@MrKai77 MrKai77 changed the title ✨ Configuration for preview animations/transitions ✨ Configuration for animations/transitions Oct 27, 2023
@MrKai77 MrKai77 linked a pull request Oct 27, 2023 that will close this issue
MrKai77 added a commit that referenced this issue Oct 27, 2023
…nimationstransitions`

✨ #65 Configuration for animations/transitions
@jacksongoode
Copy link
Author

That's beautiful! And yes, sometimes less is more in terms of user configuration and ease! Wonderful job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants