Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 "Double-click trigger key to trigger Loop" recognized incorrectly #187

Closed
2 tasks done
MaximilianZenz opened this issue Jan 24, 2024 · 3 comments · Fixed by #189
Closed
2 tasks done

🐛 "Double-click trigger key to trigger Loop" recognized incorrectly #187

MaximilianZenz opened this issue Jan 24, 2024 · 3 comments · Fixed by #189
Assignees
Labels

Comments

@MaximilianZenz
Copy link

Bug Description

I currently use loop with doup press left cmd but it also trigger when I for example press cmd+option or cmd+shift or cmd+ctrl which is really annoying because for example the screenshot shortcut uses cmd bus crtl/shift.

Steps To Reproduce

  • bind loop to trigger with double pressing cmd or any other of the described keys
  • hold the trigger key and press the another key (cmd/option/control/shift) shortly after
  • loop will trigger even if it shouldn't trigger

Expected Behavior

that loop doesn't trigger when i hold the trigger key and press any other of cmd,option,ctrl or shift

Actual Behavior

loop triggers when holding the trigger key and pressing any other of the ones described

Screenshots

No response

MacOS Version

Sonoma 14.2.1

Loop Version

1.0.0.beta.14

Additional Context

This already happened with older Loop Versions

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@MaximilianZenz MaximilianZenz changed the title 🐛 2nd key with double klick recognised incorrectly 🐛 2nd key with double klick enabled recognised incorrectly Jan 24, 2024
@MaximilianZenz MaximilianZenz changed the title 🐛 2nd key with double klick enabled recognised incorrectly 🐛 trigger key with double klick enabled recognised incorrectly Jan 24, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Jan 24, 2024

I can reproduce this as well. I'll try and fix this ASAP since it's a really annoying bug!

@MrKai77 MrKai77 changed the title 🐛 trigger key with double klick enabled recognised incorrectly 🐛 "Double-click trigger key to trigger Loop" recognized incorrectly Jan 24, 2024
@MrKai77 MrKai77 self-assigned this Jan 24, 2024
@MrKai77
Copy link
Owner

MrKai77 commented Jan 24, 2024

Fixed!
Here's the build: Loop.zip
Let me know if there's any other issues!

@MaximilianZenz
Copy link
Author

Looks like it fixed the Bug. Nice work. Thank you 🙂

MrKai77 added a commit that referenced this issue Jan 25, 2024
…ey-to-trigger-loop-recognized-incorrectly

🐛 #187 "Double-click trigger key to trigger Loop" recognized incorrectly
MrKai77 added a commit that referenced this issue Jan 25, 2024
…to-trigger-loop-recognized-incorrectly`

🐛 #187 "Double-click trigger key to trigger Loop" recognized incorrectly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants