Clean up common source sets #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since we upgraded to Kotlin 1.9.x, IntelliJ has been unable to properly resolve 'kotlin.test.Test'. This turned out to be a known bug (KT-62368) set to be fixed in Kotlin 2.0. The recommended workaround for now is to depend on 'kotlin-test-junit' instead.
Common source should not directly depend on a JVM library like JUnit. Though this is effectively a non-issue because we do have JVM as one of the targets, it's still an inappropriate thing to do.
Common source should not directly depend on 'java.*' classes. Though this is effectively a non-issue because we do have JVM as one of the targets, it's still an inappropriate thing to do.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
Common source code (ones in
commonMain/andcommonTest/) are now free of JVM imports.Why it was changed
Mostly for hygiene. We don't really have any problems as we do have JVM as one of the targets, but it's still an inappropriate thing to do.