Merge pull request #207 from MrForExample/dev

Update Auto Install/Build Scripts
MrForExample · Jul 11, 2024 · e04eff9 · e04eff9
2 parents 4f760e8 + dacaf00
commit e04eff9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/_Pre_Builds/_Build_Scripts/auto_build_all.py b/_Pre_Builds/_Build_Scripts/auto_build_all.py
@@ -62,10 +62,14 @@ def build_python_wheel(dependency_dir, output_dir):
     # Build wheel and move the wheel file we just built to the output directory
     print(f"Building {dependency_dir}")
 
-    result = subprocess.run([PYTHON_PATH, "setup.py", "bdist_wheel", "--dist-dir", output_dir], cwd=dependency_dir, shell=True, text=True, capture_output=True)
+    result = subprocess.run([PYTHON_PATH, "setup.py", "bdist_wheel", "--dist-dir", output_dir], cwd=dependency_dir, text=True, capture_output=True)
     #print(f"returncode: {result.returncode} \n\n Output: {result.stdout} \n\n Error: {result.stderr}")
     build_failed = result.returncode != 0
 
+    if build_failed:
+        print(f"[Wheel BUILD LOG]\n{result.stdout}")
+        print(f"[Wheel BUILD ERROR LOG]\n{result.stderr}")
+
     print(f" Build {dependency_dir} {'Failed' if build_failed else 'Succeed'}")
     return build_failed
 

diff --git a/install.py b/install.py
@@ -31,7 +31,7 @@ def try_auto_build_all(builds_dir):
         cstr(f"Try building all required packages...").msg.print()
         result = subprocess.run(
             [PYTHON_PATH, "auto_build_all.py", "--output_root_dir", builds_dir], 
-            cwd=BUILD_SCRIPT_ROOT_ABS_PATH, shell=True, text=True, capture_output=True
+            cwd=BUILD_SCRIPT_ROOT_ABS_PATH, text=True, capture_output=True
         )
         build_succeed = result.returncode == 0