Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update on allowing user to add credentials from config #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kwchun0520
Copy link

@kwchun0520 kwchun0520 commented Jul 4, 2024

Adding function to the class, allowing user to load credentials from dictionary
usage:

config = dict()

authenticator = Authenticate(
cookie_name='my_cookie_name',
cookie_key='this_is_secret',
redirect_uri = 'http://localhost:8501',
)

authenticator.load_credentials(config)

authenticator.login()

@MrBounty
Copy link
Owner

Hello, what are the benefits of using this instead ?

It would cause issue with compatibilty because the class arguments changed.

@kwchun0520
Copy link
Author

Hi, my original thought is it is easier to incorporate with google secret manager. But Yes, you are right about the compatibility issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants