Merge pull request #49 from cvan/update-polyfill-checks

update webvr-polyfill checks
MozillaReality · Jan 5, 2018 · c6e2baa · c6e2baa
2 parents 707ecd3 + 16c36bf
commit c6e2baa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/Assets/WebGLTemplates/WebVR/webvr.js b/Assets/WebGLTemplates/WebVR/webvr.js
@@ -29,8 +29,11 @@
         if (displays.length > 0) {
           vrDisplay = displays[displays.length - 1];
 
-          // check to see if we are polyfilled
-          if (vrDisplay.displayName.indexOf('polyfill') > 0) {
+          // Check to see if we are polyfilled.
+          var isPolyfilled = (vrDisplay.deviceId || '').indexOf('polyfill') > 0 ||
+            (vrDisplay.deviceName || '').indexOf('polyfill') > 0 ||
+            vrDisplay.hardwareUnitId;
+          if (isPolyfilled) {
             showInstruction(document.querySelector('#novr'));
           } else {
             status.dataset.enabled = true;
@@ -39,8 +42,10 @@
           onAnimate();
         }
 
-        if (vrDisplay.capabilities.canPresent) {
-          entervrButton.dataset.enabled = 'true';
+        if (vrDisplay.capabilities && vrDisplay.capabilities.canPresent) {
+          entervrButton.dataset.enabled = true;
+        } else {
+          delete entervrButton.dataset.enabled;
         }
       });
     } else {

diff --git a/Build/webvr.js b/Build/webvr.js
@@ -29,8 +29,11 @@
         if (displays.length > 0) {
           vrDisplay = displays[displays.length - 1];
 
-          // check to see if we are polyfilled
-          if (vrDisplay.displayName.indexOf('polyfill') > 0) {
+          // Check to see if we are polyfilled.
+          var isPolyfilled = (vrDisplay.deviceId || '').indexOf('polyfill') > 0 ||
+            (vrDisplay.deviceName || '').indexOf('polyfill') > 0 ||
+            vrDisplay.hardwareUnitId;
+          if (isPolyfilled) {
             showInstruction(document.querySelector('#novr'));
           } else {
             status.dataset.enabled = true;
@@ -39,8 +42,10 @@
           onAnimate();
         }
 
-        if (vrDisplay.capabilities.canPresent) {
-          entervrButton.dataset.enabled = 'true';
+        if (vrDisplay.capabilities && vrDisplay.capabilities.canPresent) {
+          entervrButton.dataset.enabled = true;
+        } else {
+          delete entervrButton.dataset.enabled;
         }
       });
     } else {