Custom GitHub Actions workflow to continuously deploy main to the Heroku staging app
#9494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrlpld
force-pushed
the
9215-continous-deployment-github-action
branch
2 times, most recently
from
66dc0b9 to
50ae3b6
Compare
tbrlpld
requested review from
danielfmiranda,
fessehaye,
mmmavis and
mtdenton
tbrlpld
changed the title
main to the Heroku staging app
|
This looks good to me, but leaving this for someone else to approve so that I'm not the only one checking this out. Thanks @tbrlpld |
danielfmiranda
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Hi @tbrlpld,
This PR looks good to me. Thanks again for taking this work on and updating the documentation as well. This will be very helpful in the future.
Approved!
fessehaye
reviewed
Nov 21, 2022
fessehaye
approved these changes
Nov 21, 2022
On push and only fetch from staging. So it's a benign action. This is to test the login setup.
tbrlpld
force-pushed
the
9215-continous-deployment-github-action
branch
from
22b557c to
a867749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables a custom GitHub Actions workflow to deploy the
mainbranch to the staging app on Heroku.The custom workflow checks that the CI pipline has finished successfully, checks out the
mainbranch and pushes it to Heroku via the traditional Git push deployment.The docs are updated to reflect this change and contain information on which credentials need to be set up and how to get them.
I have tested that the Heroku access works with a simple
git fetch heroku main. This is the workflow run of the test: https://github.com/mozilla/foundation.mozilla.org/actions/runs/3492453124/jobs/5846247852Related PRs/issues: #9215