Youtube Regrets 2022 - Recommendations section #9254 #9324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I've added @tbrlpld to this PR as he's the one doing reviews from the Mozilla team |
tbrlpld
approved these changes
Sep 8, 2022
...agtailpages/templates/wagtailpages/pages/youtube-regrets-2022/fragments/recommendations.html
Outdated
Show resolved
Hide resolved
...agtailpages/templates/wagtailpages/pages/youtube-regrets-2022/fragments/recommendations.html
Outdated
Show resolved
Hide resolved
...agtailpages/templates/wagtailpages/pages/youtube-regrets-2022/fragments/recommendations.html
Outdated
Show resolved
Hide resolved
...agtailpages/templates/wagtailpages/pages/youtube-regrets-2022/fragments/recommendations.html
Outdated
Show resolved
Hide resolved
…es/youtube-regrets-2022/fragments/recommendations.html Fix whitespace. Co-authored-by: Tibor Leupold <[email protected]>
…es/youtube-regrets-2022/fragments/recommendations.html Fix whitespace. Co-authored-by: Tibor Leupold <[email protected]>
…es/youtube-regrets-2022/fragments/recommendations.html Fix whitespace. Co-authored-by: Tibor Leupold <[email protected]>
…es/youtube-regrets-2022/fragments/recommendations.html Fix whitespace. Co-authored-by: Tibor Leupold <[email protected]>
|
@siimonevans This has conflicts |
…dations-section # Conflicts: # network-api/networkapi/wagtailpages/templates/wagtailpages/pages/youtube-regrets-2022/youtube_regrets_2022.html
Youtube Regrets 2022 - Hero carousel section #9260
stevedya
approved these changes
Sep 9, 2022
|
|
||
| @media screen and (min-width: $bp-md) { | ||
| font-size: 52px; | ||
| line-height: calc(60 / 52); |
There was a problem hiding this comment.
This equals 1.15 too so we don't need it here haha
Suggested change
| line-height: calc(60 / 52); |
There was a problem hiding this comment.
If we do this, can we use values from the design system?
|
|
||
| &__title { | ||
| font-size: 30px; | ||
| line-height: calc(34 / 30); |
There was a problem hiding this comment.
My sole purpose in life is to eliminate math 🤖
Suggested change
| line-height: calc(34 / 30); | |
| line-height: 1.15; |
|
|
||
| &__recommendation { | ||
| font-size: 24px; | ||
| line-height: calc(30 / 24); |
There was a problem hiding this comment.
Suggested change
| line-height: calc(30 / 24); | |
| line-height: 1.25; |
|
|
||
| @media screen and (min-width: $bp-md) { | ||
| font-size: 28px; | ||
| line-height: calc(30 / 28); |
There was a problem hiding this comment.
Even though we are reusing a bunch it would be nice to remove this needless math haha
Suggested change
| line-height: calc(30 / 28); | |
| line-height: 1; |
|
Ups. This is already merged. |
|
@tbrlpld hahah oops! No big deal anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9254
This PR adds a recommendations section (in line with the existing 2021 component with updated copy).
Screenshots
