Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix piechart numbers #7022

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fix piechart numbers #7022

merged 1 commit into from
Jul 7, 2021

Conversation

KalobTaulien
Copy link
Contributor

@KalobTaulien KalobTaulien commented Jul 7, 2021

Partially Closes #7021

Link to sample test page: https://foundation-s-7021-pie-c-ofvcle.herokuapp.com/en/campaigns/regrets-reporter/findings/ (look at Section #1; you'll need to click into it)

Numbers should have been: [70.9, 7.67, 21.4]. These are now fixed.

@mofodevops mofodevops temporarily deployed to foundation-s-7021-pie-c-ofvcle July 7, 2021 03:10 Inactive
@KalobTaulien KalobTaulien requested review from kristinashu and Pomax July 7, 2021 03:23
@github-actions
Copy link

github-actions bot commented Jul 7, 2021

This PR introduces visual differences. Click here to inspect the diffs.

Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll let Kristina make doubly sure it's correct

Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Numbers and colors look correct!

@Pomax Pomax merged commit af226a8 into master Jul 7, 2021
@Pomax Pomax deleted the 7021-pie-chart-number-adjustments branch July 7, 2021 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[YouTube QA] Data in graphs is wrong
4 participants