Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mergify for dependabot PRs only for now #4372

Merged
merged 2 commits into from
Mar 24, 2020
Merged

add mergify for dependabot PRs only for now #4372

merged 2 commits into from
Mar 24, 2020

Conversation

patjouk
Copy link
Contributor

@patjouk patjouk commented Mar 19, 2020

Closes MozillaFoundation/mofo-devops#746

Add Mergify for Dependabot PRs only. I'm adding strict as a rule to make sure that the PR is always up to date before merging.
Rule for Dependabot: https://doc.mergify.io/examples.html#dependabot

Mergify has a "simulator" to validate your rules
PR #4365 would be merged
Screenshot 2020-03-19 at 13 46 58

PR #4358 wouldn't be merged
Screenshot 2020-03-19 at 13 57 53


If we're happy with the results, we could also add it to all PRs, using a label ready-to-merge to prevent unwanted merge.

@patjouk patjouk added the devops label Mar 19, 2020
@patjouk patjouk added this to the Mar 23 milestone Mar 19, 2020
@patjouk patjouk requested a review from cadecairos March 19, 2020 12:59
@patjouk patjouk temporarily deployed to foundation-s-mergify-423unzby8 March 19, 2020 12:59 Inactive
@patjouk
Copy link
Contributor Author

patjouk commented Mar 24, 2020

Since we had a random person approving a PR on wagtail-donate, I wanted to make sure that it would not automatically merged. Tried with #4391: it wouldn't be merged :)

@patjouk patjouk merged commit ef526e4 into master Mar 24, 2020
@patjouk patjouk deleted the mergify branch March 24, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore using Bors or mergify
2 participants