Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Delete YoutubeRegretsReporterExtensionPage #12573

Merged

Conversation

AdalbertoMoz
Copy link
Contributor

@AdalbertoMoz AdalbertoMoz commented Jul 1, 2024

Description

This PR removes the YoutubeRegretsReporterExtensionPage model, template, and factories. Additionally, it includes a migration to delete the Page from the database, as it is no longer used in Production (tested locally with the Production database).

Link to sample test page: https://foundation-s-feature-12-cvztwh.herokuapp.com/
Related PRs/issues: #12217

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data? Yes, deleted a factory
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

@AdalbertoMoz AdalbertoMoz self-assigned this Jul 1, 2024
@AdalbertoMoz AdalbertoMoz temporarily deployed to foundation-s-feature-12-cvztwh July 2, 2024 19:35 Inactive
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @AdalbertoMoz

@AdalbertoMoz AdalbertoMoz force-pushed the feature/12217-delete-YoutubeRegretsReporterExtensionPage branch from c3474cf to 5007665 Compare July 3, 2024 21:48
@AdalbertoMoz AdalbertoMoz force-pushed the feature/12217-delete-YoutubeRegretsReporterExtensionPage branch from 5007665 to f2f268e Compare July 3, 2024 23:35
@AdalbertoMoz AdalbertoMoz merged commit 52a2fdb into main Jul 3, 2024
6 checks passed
@AdalbertoMoz AdalbertoMoz deleted the feature/12217-delete-YoutubeRegretsReporterExtensionPage branch July 3, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants