Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom donate page footer #12236

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

robdivincenzo
Copy link
Collaborator

@robdivincenzo robdivincenzo commented Apr 19, 2024

Description

This PR removes the custom donate page footer. The footer should now inherit the default foundation footer.

Link to sample test page: https://foundation-s-tp1-33-120-mtgip5.herokuapp.com/en/donate
Related PRs/issues: #12021 TP1-33

To test

  1. Go to https://foundation-s-tp1-33-120-mtgip5.herokuapp.com/en/donate and confirm the default foundation footer is loading
  2. Go to [/donate/help](https://foundation-s-tp1-33-120-mtgip5.herokuapp.com/en/donate/help and confirm the default foundation footer is loading

┆Issue is synchronized with this Jira Story

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-33-120-mtgip5 April 19, 2024 15:00 Inactive
Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design looks good! Ty!

Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robdivincenzo! Approved 👍

@robdivincenzo robdivincenzo temporarily deployed to foundation-s-tp1-33-120-mtgip5 April 23, 2024 14:12 Inactive
@robdivincenzo robdivincenzo merged commit d68b335 into main Apr 23, 2024
6 checks passed
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

This PR was merged on April 23rd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants