Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wagtail-ab-testing from 0.9 to 0.10 #12090

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 25, 2024

Bumps wagtail-ab-testing from 0.9 to 0.10.

Release notes

Sourced from [wagtail-ab-testing's releases](https://github.com/wagtail-nest/wagtail-ab-testing/releases).

v0.10

What's Changed

Full Changelog: [https://github.com/wagtail-nest/wagtail-ab-testing/compare/v0.9...v0.10](https://github.com/wagtail-nest/wagtail-ab-testing/compare/v0.9...v0.10)

Changelog

Sourced from [wagtail-ab-testing's changelog](https://github.com/wagtail-nest/wagtail-ab-testing/blob/main/CHANGELOG.md).

[0.10] - 2024-03-22

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

┆Issue is synchronized with this Jira Task

@dependabot dependabot bot added backend dependencies Pull requests that update a dependency file engineering pip Used for dependabot PR's having to do with pip/python labels Mar 25, 2024
@jhonatan-lopes jhonatan-lopes self-assigned this Mar 28, 2024
@dependabot dependabot bot force-pushed the dependabot/pip/wagtail-ab-testing-0.10 branch 3 times, most recently from 70d9db8 to 230def1 Compare April 22, 2024 14:11
Bumps [wagtail-ab-testing](https://github.com/wagtail-nest/wagtail-ab-testing) from 0.9 to 0.10.
- [Release notes](https://github.com/wagtail-nest/wagtail-ab-testing/releases)
- [Changelog](https://github.com/wagtail-nest/wagtail-ab-testing/blob/main/CHANGELOG.md)
- [Commits](wagtail-nest/wagtail-ab-testing@v0.9...v0.10)

---
updated-dependencies:
- dependency-name: wagtail-ab-testing
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/wagtail-ab-testing-0.10 branch from 230def1 to ef285a2 Compare April 22, 2024 15:45
@jhonatan-lopes
Copy link
Contributor

When we setup wagtail-ab-testing, we had to do some customisation to get around the CSP:

In order to make wagtail-ab-testing compatible with our CSP, the main script and template tag had to be overwritten. The script on templates/wagtail_ab_testing/script.html was modified to pass values through a json_script tag (as Django recommends) and a nonce was added to the scripts.

The wagtail_ab_testing_script template tag was rewritten at networkapi.wagtailcustomization.templatetags.wagtailcustom_tags to pass the request to the script so that it can pick up the nonce value from request (request.csp_nonce).

To complete this upgrade, we need to remove:

Also, remove the wagtail-ab-testing section from the upgrading docs

Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielfmiranda danielfmiranda merged commit 1afe5cc into main Aug 30, 2024
6 checks passed
@danielfmiranda danielfmiranda deleted the dependabot/pip/wagtail-ab-testing-0.10 branch August 30, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file engineering pip Used for dependabot PR's having to do with pip/python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants