-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various minor issues #11960
Fix various minor issues #11960
Conversation
6a3c075
to
fea35ba
Compare
fea35ba
to
bef46d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mmmavis, I just have a minor observation
network-api/networkapi/templates/fragments/buyersguide/category_dropdown.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nancyt1 I just took a look but couldn't reproduce the issue you found. Do you mind checking again? ![]() |
@mmmavis ![]() |
@nancyt1 Ah I see. Thanks for pointing that out. In that case could I ask you to help update this image with upper case text? If it takes too much effort, I can file a new ticket for us to tackle later |
@nancyt1 Thanks! And sorry I didn't realize you included the link in the initial ticket already. Time to get some coffee Mavis ☕ |
So that we can have these old tickets addressed and closed sooner, I've replaced the current ding images with the new ones. In the future, we should move towards excluding text from images. This will require some dev effort but should be pretty strightforward to implement. @nancyt1 Please verify the changes here: https://foundation-s-fix-minor--meywng.herokuapp.com/en/privacynotincluded/gas-finish-hit-speak-eye-store/ Thanks! |
@mmmavis hm, they still show up as lowercase for me. Can you screenshot what you see? |
@nancyt1 sorry, I updated everything except the English version. This should be fixed now 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! (:
Related PRs/issues:
Review app login: https://foundation-s-fix-minor--meywng.herokuapp.com/cms/ (credential:
admin2/admin2password
)#9666 Enlarged nav dropdown's vertical gap to 16px
Commit: 2e9c599
Test page: https://foundation-s-fix-minor--meywng.mofostaging.net/en/who-we-are/
#10857 Adjusted PNI category dropdown button font size
Commit: b8b8de3
Test page: https://foundation-s-fix-minor--meywng.mofostaging.net/en/privacynotincluded/
#9941 Capitalized all instances of lowercase *PNI
Commit: 17f1f19
Test page: https://foundation-s-fix-minor--meywng.mofostaging.net/en/privacynotincluded/
Note for code reviewer: Commit includes a migration file due to updating a
verbose_name
but I'm debating if this change is really worth having a migration file for or we just leave this particular instance of lowercase *PNI as is.#10121 Made spacer available on ArticlePage
Commits: ddccad1 and fea35ba
Test page: https://foundation-s-fix-minor--meywng.herokuapp.com/cms/pages/127/edit/ (credential:
admin2/admin2password
)