-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fellowships directory pages #1046
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,15 @@ | ||
{% extends "fellowships-base.html" %} | ||
|
||
{% block template_id %}fellows-directory{% endblock %} | ||
|
||
{% block body %} | ||
fellows directory | ||
<div class="row"> | ||
<div class="col-md-12 col-lg-9"> | ||
<div class="mb-4"> | ||
<h1 class="h1-white">Fellows Directory</h1> | ||
</div> | ||
</div> | ||
</div> | ||
|
||
<div id="fellows-directory-featured-fellows"></div> | ||
{% endblock %} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{% extends "fellowships-base.html" %} | ||
|
||
{% block template_id %}fellows-directory-{{type|slugify}}{% endblock %} | ||
|
||
{% block body %} | ||
<div id="fellowship-breadcrumb"> | ||
<ol class="breadcrumb"> | ||
<li class="breadcrumb-item small-gray"> | ||
<a href="{% url 'fellowships-directory' %}" class="small-gray">Directory</a> | ||
</li> | ||
<li class="breadcrumb-item small-gray active text-capitalize"> | ||
{{ type }} Fellows | ||
</li> | ||
</ol> | ||
</div> | ||
|
||
<div class="row"> | ||
<div class="col-12"> | ||
<div class="mb-4"> | ||
<h1 class="h1-white text-capitalize">{{ type }} Fellows</h1> | ||
</div> | ||
</div> | ||
</div> | ||
|
||
<div id="fellows-directory-fellows-by-type" data-type="{{type}}"> | ||
</div> | ||
{% endblock %} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
#multipage-nav-mobile { | ||
background: #f2f2f2; | ||
background: $off-white; | ||
|
||
.multipage-nav { | ||
div:first-child { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,13 +23,14 @@ import fellowships from './fellowships'; | |
const SHOW_MEMBER_NOTICE = false; | ||
|
||
// To be populated via XHR... | ||
let env, networkSiteURL; | ||
let env, networkSiteURL, pulseApiURL; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this going to cause problems when promoting heroku pipelines? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh or is it pulling this from the environment json view that the server exposes? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @alanmoo I think it should be fine. I'm following exactly how we are doing to get |
||
let main = { | ||
init () { | ||
this.fetchEnv((envData) => { | ||
env = envData; | ||
networkSiteURL = env.NETWORK_SITE_URL; | ||
pulseApiURL = env.PULSE_API_DOMAIN; | ||
|
||
// HEROKU_APP_DOMAIN is used by review apps | ||
if (!networkSiteURL && env.HEROKU_APP_NAME) { | ||
|
@@ -247,7 +248,7 @@ let main = { | |
} | ||
|
||
// Fellowships pages related components | ||
fellowships.injectReactComponents(); | ||
fellowships.injectReactComponents(pulseApiURL); | ||
} | ||
}; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put a comment in describing what this is doing (vs, say, the existing
person.jsx
component)?