Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build static fellowships directory page #955

Closed
alanmoo opened this issue Jan 12, 2018 · 15 comments
Closed

Build static fellowships directory page #955

alanmoo opened this issue Jan 12, 2018 · 15 comments
Assignees

Comments

@alanmoo
Copy link
Contributor

alanmoo commented Jan 12, 2018

We're going to have a dynamic directory, but the work on that might take longer than it does to get to building this page. If that's the case, grab the JSON from the desired pulse profiles and use that to generate a static page.

@alanmoo
Copy link
Contributor Author

alanmoo commented Jan 12, 2018

@auremoser Can you or Amy (github handle?) build a list of the urls for pulse profiles of current fellows?

@auremoser
Copy link

auremoser commented Jan 16, 2018

Sure, Amy's handle is @community-impact.

I sent the fellows a message to create profiles and we added an issue in the moz-fellows repo for it but I am not sure all of them were able to 😢 . I'll remind them.

I think I'll need to request their profile links from them anyway, because the search doesn't seem to return for their names:
screen shot 2018-01-16 at 1 06 26 pm

Even when they have a profile:

I added a request in slack for profile links. One thing I noticed too, is that even when you have a profile, you can't really search for yourself as above, and it's hard to find your URL because when you're logged in it always displaces as profile/me rather than profile/NUMBER.

More soon @alanmoo !

UPDATE:

Alumni Fellows:

@alanmoo
Copy link
Contributor Author

alanmoo commented Jan 16, 2018

Yup, that's expected and one of the things on our roadmap is improving the search.

As long as the have a google account, they should be able to log in with it on Pulse and that'll allow them to create a profile.

@auremoser
Copy link

FYI, updated the above comment to include more fellows' profiles.
Trying to get through that this week!

@xmatthewx
Copy link
Contributor

Sharing a list of links to all the profiles.

@auremoser
Copy link

I added all the profiles as of today, including some alumni fellows (mostly OWF and Science because that's my focus area but I found some senior fellows too, so I add those.

@mmmavis
Copy link
Collaborator

mmmavis commented Feb 2, 2018

@alanmoo @xmatthewx @auremoser What URLs do we wanna use for specific fellowship type pages under Directory?

I'm thinking

  • /fellowships/directory/senior
  • /fellowships/directory/science
  • /fellowships/directory/open-web
  • /fellowships/directory/tech-policy
  • /fellowships/directory/media

Thoughts?

@auremoser
Copy link

I think these are logical @mmmavis ! I wonder if we would want to abbreviate to "dir" or something so the URL isn't quite so long. What would be the full URL breadcrumb here? Something like foundation.mozilla.org/fellowships/directory/science/2016?

It's probably too late to punt "directory" as a term, but I also like the following as options (they feel a bit warmer?, and echo community programs like this directory example which includes but is not forever limited to fellows)

  • /fellowships/index/ we could also do fellowships/codex though I'm not sure the "code" pun would come through 😢
  • /fellowships/community/
  • /fellowships/people/

@xmatthewx
Copy link
Contributor

Let's stick with fellowships/directory. I like people, but we use that for a top level view. That view will evolve this spring to stories about people (including fellows). It'll be warm and fuzzy. Community connotes something broader and feels ambiguous.

mmmavis added a commit that referenced this issue Feb 13, 2018
* Related to #955 - fellowships directory pages
mmmavis added a commit that referenced this issue Feb 15, 2018
* Related to #955 - fellowships directory pages
@mmmavis
Copy link
Collaborator

mmmavis commented Mar 1, 2018

We have dynamic directory working already so I'm closing this ticket.

See this review app: https://foundation-mofostaging--pr-996.herokuapp.com/fellowships/directory/

Profiles are pulled from Pulse API directly. To make someone show on the directory page, make sure his/her Pulse profile has the following meta set (we can do this on Pulse backend's admin interface)

  • profile_type is set to fellow
  • program_type is properly set
  • program_year is properly set

@mmmavis mmmavis closed this as completed Mar 1, 2018
@auremoser
Copy link

Whoo, looks slick, what's the best way to add a person (I notice Joey K. Lee @joeyklee is not listed among Science Fellows 2015) but I'm happy to add him.

  • Do I have access to the profile_type/program_type entries that @mmmavis mentions?
  • Should I just ask him to make a profile again?

What's the best way to do this from the above/other options?

Thank you!

@xmatthewx
Copy link
Contributor

Yes, staff will have access to add and update profiles for fellows. As I mentioned in slack, there's a hiccup we're squashing now that will make it much simpler. More soon....

@joeyklee
Copy link

joeyklee commented Mar 5, 2018

Thanks @auremoser! let me know if there's anything I can do to help.

@auremoser
Copy link

auremoser commented Mar 5, 2018

Yes @joeyklee , would you mind making a Pulse Profile? We'll be using it in the spiffy new website which will feature a fellows' directory! I couldn't find your profile in my searches before, so I'm not sure we asked you to make one.
screen shot 2018-03-05 at 11 52 07 am

Thanks

@joeyklee
Copy link

joeyklee commented Mar 5, 2018

@auremoser oh whoops! I may have overlooked that mail. Anyhoo, you should find it under my email: [email protected]

mmmavis added a commit that referenced this issue Mar 6, 2018
* Set stage for fellowships pages w/ django template (#961)

* Set stage for fellowships pages w/ django template

* Adding some stub urls for the fellowships site. (#971)

* Adding some stub urls for the fellowships site.

* Update some of the urls a bit more

* fellowships homepage wireframe (#965)

* Fix review apps for fellows (#1010)

* Test commit

* Find out which url is it resolving to

* Fix stuff

* Remove debugging stuff

* fixed rebase conflicts

* Fellowships support page (#1006)

Fellowships support page

* fixed rebase conflicts

* Responsive fellowships nav & better multi-page nav on mobile (#1020)

* Related to #1019 - repsonsive fellowships nav + #977 - better multi-page nav on mobile

* Updated fellowships homepage (#1042)

* updated fellowships homepage

* updated fellowships support page (#1049)

* Fellowships directory pages (#1046)

* Related to #955 - fellowships directory pages

* Update fellowships type pages (#1059)

* added illustration to fellowship types page and fellowships support page (#1061)

* made fellowships work use the new master template (#1069)

* updated /apply page so it's in 'application open' state (#1070)

* More assets (#1073)

* added more assets & created a svg sub-folder

* added hero image to fellowships homepage

* Related to #1062 - hide affiliation meta from front end (#1075)

* design tweaks (#1081)

* design tweaks

* show fellow location in fellowships directory (#1103)

* Added loading icon (#1093)

* Related to #1045 - added loading icon

* Featured fellows (#1112)

* added featured fellows on fellowships homehomepomepage (hardcoded)

* hide some incomplete content for now (#1113)

* Fixes #1092 - added back missing icon & ran task to optimize svgs (#1108)

* Added placeholder headshot to Person component (#1119)

* Related #1114 - added placeholder headshot

* Updated fellowships homepage content and layout again (#1122)

* Related to #1120 - updated fellowships homepage content and layout again
* Related to #1124 - hero banner adjustment

* Fixed #1096 - replaced a svg (#1123)

* Content changes to apply page (#1127)

* Related to #1116 - content changes to apply page

* Fixed broken 'see work' link (#1129)

* Fixed #1128 - fixed broken 'see work' link

* Fixes #1144 - fixed a fellow's social link (#1145)

* remmoved 'senior fellow' section from directory pages (#1150)

* redirected /fellowship to /fellowships (#1149)

* redirected /fellowship to /fellowships

* removed an extra line

* Fellowships improvements (#1157)

* code improvement

* removed a few empty files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants