Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YTR 2022 | Top hero intro section and moving stats upwards #9253

Closed
3 of 4 tasks
cdanfon opened this issue Aug 23, 2022 · 7 comments
Closed
3 of 4 tasks

YTR 2022 | Top hero intro section and moving stats upwards #9253

cdanfon opened this issue Aug 23, 2022 · 7 comments

Comments

@cdanfon
Copy link

cdanfon commented Aug 23, 2022

Link to design - https://www.figma.com/file/XtEAabujYbKaP5mLnCtvVS/YouTube-User-Control-Report-Landing-Page?node-id=0%3A1

ACs:

  • Copy matches content in this document
  • Content is broken down as per the new design
  • Stats appear at the end of this section and continue to be animated and match the new colour
  • Two illustrations to appear on each side of the stats as per the new design

TO DO: clarify the use of illustration on tablet & mobile

@cdanfon cdanfon changed the title YT 2022 | Top hero intro section and moving stats upwards YTR 2022 | Top hero intro section and moving stats upwards Aug 23, 2022
@cdanfon
Copy link
Author

cdanfon commented Aug 31, 2022

@beccaklam to:

  1. confirm where the button should be getting the content (if it's going to be a pdf or a publication page)
  2. confirm if the report will be served in different languages
  3. clarify the use of illustration on tablet & mobile

@cdanfon
Copy link
Author

cdanfon commented Sep 6, 2022

@kristinashu This is now ready for MoFo to review, please note my comments on Content.

@cdanfon
Copy link
Author

cdanfon commented Sep 6, 2022

I can't satisfy AC #1 as the content has been changed since Steve completed this ticket.

Content changes would need to be re-factored towards the estimate.

@kristinashu
Copy link

This looks amazing, thank you so much! And sorry for those last minute copy changes.

There was also a stakeholder request to make the subtitle stand out more. Nancy mocked it up (see screep cap from Figma below). Should this be done here or in a new ticket?
image

cc @nancyt1 in case you see anything else

@cdanfon
Copy link
Author

cdanfon commented Sep 7, 2022

NB Removed AC the following AC which will be done as part of a separate ticket:

@cdanfon
Copy link
Author

cdanfon commented Sep 7, 2022

Hey @kristinashu if it's a one-off change we can update it within this ticket, @siimonevans are you OK to pick up this small change request please?

Thanks!

@siimonevans
Copy link
Collaborator

PR to address the above here.

tbrlpld added a commit that referenced this issue Sep 9, 2022
Youtube Regrets 2022 - Top hero intro section #9253
@cdanfon cdanfon closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants