Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNI] Create a BuyersGuideContentCategory snippet #9111

Closed
1 of 4 tasks
tbrlpld opened this issue Jul 14, 2022 · 4 comments
Closed
1 of 4 tasks

[PNI] Create a BuyersGuideContentCategory snippet #9111

tbrlpld opened this issue Jul 14, 2022 · 4 comments
Assignees
Labels
backend buyer's guide 🛍 Issues related to the buyer's guide engineering p1 this work should get done first product Drive Products Forward
Milestone

Comments

@tbrlpld
Copy link
Collaborator

tbrlpld commented Jul 14, 2022

Description

Simple snippet to categorize the different kinds of articles.

Fields:

  • title: CharField
  • slug: SlugField

Acceptance criteria

@tbrlpld tbrlpld added this to the PNI Dev 2022 milestone Jul 14, 2022
@tbrlpld tbrlpld added buyer's guide 🛍 Issues related to the buyer's guide backend labels Jul 14, 2022
@fessehaye fessehaye added the p1 this work should get done first label Jul 18, 2022
@tbrlpld
Copy link
Collaborator Author

tbrlpld commented Aug 2, 2022

Since this is a PNI ticket, it won't go to staging. We can to QA once the PNI review app is ready.

@cdanfon cdanfon added the product Drive Products Forward label Aug 4, 2022
@tbrlpld tbrlpld assigned cdanfon and unassigned tbrlpld Aug 8, 2022
@tbrlpld
Copy link
Collaborator Author

tbrlpld commented Aug 8, 2022

@tbrlpld
Copy link
Collaborator Author

tbrlpld commented Aug 8, 2022

Note: A bug in Wagtail unfortunately prevents the option from constraining the slug uniqueness only per locale. See also: wagtail/wagtail#8918. Because of this issue, translators will have to manually set a unique slug if the translated title matches any other language.

@tbrlpld tbrlpld assigned tbrlpld and unassigned tbrlpld Aug 9, 2022
@cdanfon
Copy link

cdanfon commented Aug 12, 2022

@tbrlpld

Couldn't satisfy AC #2

Steps to reproduce:

  1. Tried to translate numerous snippets at once - it didn't translate
  2. When trying to translate 1 snippet - 500 error came up

Aware that the last 2 ACs cannot be tested due to bug #8918 referenced by Tibor

@cdanfon cdanfon closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend buyer's guide 🛍 Issues related to the buyer's guide engineering p1 this work should get done first product Drive Products Forward
Projects
None yet
Development

No branches or pull requests

3 participants