Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PNI] - Create PNI Article Page [Backend] #9083

Closed
10 of 12 tasks
fessehaye opened this issue Jul 13, 2022 · 10 comments
Closed
10 of 12 tasks

[PNI] - Create PNI Article Page [Backend] #9083

fessehaye opened this issue Jul 13, 2022 · 10 comments
Assignees
Labels
backend buyer's guide 🛍 Issues related to the buyer's guide engineering p1 this work should get done first product Drive Products Forward
Milestone

Comments

@fessehaye
Copy link
Contributor

fessehaye commented Jul 13, 2022

https://www.figma.com/file/GwdoUiY4fzVyeLfXsAJGPq/*Privacy-Not-Included-Website?node-id=2303%3A126762

  • This can basically be a copy of the blog page type
  • Authors
    • Already exists on the blog page. But, is a little different here.
    • Since we have no author index, the names should not be links.
    • Orderable through-model to profile.
  • Content category
  • Related articles (TBD)
    • Similar to the “related articles” for the “product categories”, this can be one list that is split and rendered in two locations on the page.
    • Orderable, through-model to other article pages.
  • Body – same as blog.
  • Banner image – same as blog
  • Newsletter CTA is frontend only.

Dev Tasks:

  • Create backend page type
  • Add factors for new page type

Acceptance Criteria:

  • PNI Article Page Type Available
  • Article Page Type only available under PNI content index page
  • As a Wagtail user I can add Authors to the article and order them manually
  • As a Wagtail user I can add more than 1 content category
  • As a Wagtail user I can order the content categories using the same approach as per [PNI] Create a BuyersGuideContentCategory snippet #9111
  • As a Wagtail user I can add related articles
  • As Wagtail user I can add locations on the page that are orderable through-model to other article pages.
  • As Wagtail user I can a 'body' field to the article
  • As Wagtail user I can I can add a 'banner image' field to the article
  • As Wagtail user I can add a 'Newsletter CTA' to the article that only shows front end

image

image

@fessehaye fessehaye added this to the PNI Dev 2022 milestone Jul 13, 2022
@fessehaye fessehaye changed the title [PNI] - Create PNI Article Page [PNI] - Create PNI Article Page [Backend] Jul 14, 2022
@fessehaye fessehaye added the p1 this work should get done first label Jul 18, 2022
@beccaklam
Copy link

@tbrlpld Re: authors did we want to link to the author index we're using for the foundation site? cc: @kristinashu @nancyt1

@tbrlpld
Copy link
Collaborator

tbrlpld commented Jul 19, 2022

@beccaklam My first hunch was not. That is because currently there isn't really a central profile/author index. We have separate ones for blog and research hub. Maybe this is something we could handle more centrally? The question there would be what related posts should we show?

@kristinashu
Copy link

In terms of content entry: Both blog and research hub pull info from Profile https://foundation.mozilla.org/cms/snippets/wagtailpages/profile/, right? It would be nice to be able to pull the names from there rather than having to add them in again.

In terms of IU and what our audience see: I agree that, at this stage, we should not make the names clickable.

@tbrlpld
Copy link
Collaborator

tbrlpld commented Jul 19, 2022

@kristinashu Yes, we will definitely be pulling the information from the profiles. And yes, these should no be links for now until we make a decision where we would want to link to and what to display there.

@nancyt1 nancyt1 removed their assignment Jul 19, 2022
@cdanfon cdanfon added the product Drive Products Forward label Aug 4, 2022
@tbrlpld
Copy link
Collaborator

tbrlpld commented Aug 9, 2022

@cdanfon This is now ready on the preview app: https://foundation-pni-2022.herokuapp.com/cms/pages/1444/

@cdanfon
Copy link

cdanfon commented Aug 12, 2022

@tbrlpld A few questions regarding some ACs:

- As a Wagtail user I can add more than 1 content category - There's a limit of 2, is this intended?
- As Wagtail user I can add locations on the page that are orderable through-model to other article pages. I couldn't add locations to the page
- As Wagtail user I can I can add a 'banner image' field to the article I can add an 'image' to the back end, however this won't show in the FE, is that the expected behaviour, or should the image appear even if not styled?
- As Wagtail user I can add a 'Newsletter CTA' to the article that only shows front end This field is not present in the BE (screenshot attached)

![Screenshot 2022-08-12 at 13.11.51.png](https://images.zenhubusercontent.com/624c0bfa(994c73e54a68130b/37ddda8f-d27c-4f3e-b40e-37fc94a84490)

@cdanfon cdanfon assigned danielfmiranda and unassigned tbrlpld and cdanfon Aug 15, 2022
@danielfmiranda
Copy link
Collaborator

Hi @nancyt1 @beccaklam!

I was wondering if you could please help me find the answer to some of the questions above:

  • As a Wagtail user I can add more than 1 content category
    • If I remember correctly there was discussion to limit this at 2, similar to how blog pages are limited to two topics, however, I was wondering if you could please confirm if this is the case
  • As Wagtail user I can add locations on the page that are orderable through-model to other article pages.
    • I am not too familiar of this ask, I was wondering if one of you or @fessehaye could provide more context on this one please.**
  • As Wagtail user I can add a 'Newsletter CTA' to the article that only shows front end
    • Is the newsletter sign up box supposed to show up on every product page, or should the user be able to select whether or not they want the box to appear. (we can have it default to yes/no). Also, which style of sign up box would this be: the "popout" style or the new "PNI" Style

@cdanfon to answer the question "I can add an 'image' to the back end, however this won't show in the FE, is that the expected behaviour, or should the image appear even if not styled?":

  • I just tested this out on my local machine, and it appears that this field is covered by the "hero image" field in the CMS. However, since this ticket was just for the back end work, the image appears, however it is unstyled as this is going to take place in the front end ticket 👍

image

@nancyt1
Copy link
Collaborator

nancyt1 commented Aug 16, 2022

Hi @danielfmiranda !

  • Yes we should still limit to 2 categories
  • I'm unsure what this question is asking, what do you mean by locations?
  • And yes, newsletter cta should show up on every article page and in the PNI style. Here's the link to the most recent design.

@danielfmiranda
Copy link
Collaborator

Thanks @nancyt1!

In regards to the "Location" question, I had a discussion with @beccaklam and we believe that this line is actually referring to the "Related Articles" which has been implemented.


@cdanfon it looks like we have the answers to these questions now :D

  • As a Wagtail user I can add more than 1 content category_ - There's a limit of 2, is this intended?
    - (Yes, this is intended)
  • As Wagtail user I can add locations on the page that are orderable through-model to other article pages._ I couldn't add locations to the page
    - (This is referring to the "Related Articles" section, I pulled this branch and can confirm that you can set these)
  • As Wagtail user I can I can add a 'banner image' field to the article_ I can add an 'image' to the back end, however this won't show in the FE, is that the expected behaviour, or should the image appear even if not styled?
    - (The image does appear in the template, though unstyled, as the styling takes place in 9104 - Create PNI Article Page [Frontend] #9238 )
  • As Wagtail user I can add a 'Newsletter CTA' to the article that only shows front end_ This field is not present in the BE (screenshot attached)
    - (This work is also taken care of in the front end ticket 9104 - Create PNI Article Page [Frontend] #9238)

@cdanfon
Copy link

cdanfon commented Aug 17, 2022

All good, thanks @danielfmiranda

@cdanfon cdanfon closed this as completed Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend buyer's guide 🛍 Issues related to the buyer's guide engineering p1 this work should get done first product Drive Products Forward
Projects
None yet
Development

No branches or pull requests

7 participants