-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event tracking to petition page template #1066
Comments
Just flagging that there is an existing issue #1012 with the sign up form events, which are currently not firing |
The form sign up events appear to now work properly, so we can add this tracking. |
I'm seeing an event wired for form submit already: ReactGA.event({
category: `petition`,
action: `form submit tap`,
label: `Petition form submitted`
}); I think it only fires when the form is successfully validated...do you want it to always fire when a user clicks on the button even if the form is invalid? Also...I don't see any social share buttons. Should I? |
There should be one social share button right now in |
the social buttons appear after submitting the petition. @ScottDowne is revising that now. good question. i think that's okay. this will fire if it passes validation, but server fails? later, we should consider events for validation failure and server failure, because we currently depend on a human to notice and report it. |
@gvn to answer your first question, I think sending the event on success is probably more useful, so if that's already there this is probably now a super low priority. However, in the past, I have sent events if the form fails and with the type of validation error they got, but I don't think it's ever been useful? I normally would just consult vojtech on what events he wants. |
We're now directing campaign traffic to pages like /campaigns/equifax-breach/. We need to add analytics tracking to better understand conversion, bounces, and traffic that continues onto the site.
We have event tracking set up already on our sign up form, so this can follow that pattern.
cc @alanmoo to triage
spreadsheet of other events on pulse and site for reference.
The text was updated successfully, but these errors were encountered: