Merge pull request #9030 from mozilla/add-pyright-type-checking

Add pyright type checking

.github/workflows/continous-integration.yml

@@ -97,6 +97,9 @@ jobs:
       - name: Coveralls
         run: coveralls
         continue-on-error: true
+      - name: PyRight
+        run: npm run pyright
+        continue-on-error: true
 
   test_percy:
     name: Percy CI

docker-compose.yml

@@ -18,6 +18,7 @@ services:
     volumes:
       - .:/app:delegated
       - node_modules:/app/node_modules/:delegated
+      - dockerpythonvenv:/app/dockerpythonvenv/:delegated
     depends_on:
       - backend
 

package.json

@@ -42,6 +42,7 @@
     "playwright:ci": "run-p --race server playwright:integration",
     "playwright:integration": "wait-on -i 3000 http://localhost:8000/cms && playwright test ./tests/integration.spec.js",
     "precommit": "npm run test",
+    "pyright": "pyright",
     "server": "python network-api/manage.py runserver 0.0.0.0:8000",
     "server:silent": "python network-api/manage.py runserver 0.0.0.0:8000 >> server.log 2>&1",
     "start": "docker-compose up",
@@ -114,6 +115,7 @@
     "eslint-plugin-react": "^7.25.1",
     "optipng-bin": "^7.0.0",
     "prettier": "^2.3.2",
+    "pyright": "^1.1.256",
     "stylelint": "^13.13.1",
     "stylelint-config-standard": "^20.0.0",
     "stylelint-prettier": "^1.2.0",

pyrightconfig.json

@@ -0,0 +1,16 @@
+{
+  "include": [
+    "network-api/networkapi"
+  ],
+  "exclude": [
+    "**/node_modules",
+    "**/__pycache__",
+    "**/migrations"
+  ],
+  "extraPaths": [
+    "./dockerpythonvenv/lib/python3.9/site-packages/"
+  ],
+  "venvPath": "dockerpythonvenv",
+  "pythonVersion": "3.9",
+  "pythonPlatform": "Linux"
+}