readMembers and registerMember functions added. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated jsonRW file with readMembers function which returns all the member objects as an array and added registerMember function with the ability to add members to the json file.
Added register member post route.
There was a problem hiding this comment.
The recommended solution would be to have two generalized functions only (ex: readJSON and writeJSON). A good practice in modifying external files is to read the file, store it in a variable, modify the necessary values and then write it back out.
In the server-client environment that NodeJS is normally used in, it is recommended to implement async so that the JSON R/W module executes one operation at a time in a queue, in order to prevent data loss or duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated jsonRW file with readMembers function which returns all the member objects as an array and added registerMember function with the ability to add members to the json file. #3
Added basic express calls to index and require all the modules in index.
Added post Endpoint for /api/v1/members/register. #1