Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup does not use cached download of sscache #107

Open
kohtala opened this issue Apr 11, 2024 · 2 comments
Open

Setup does not use cached download of sscache #107

kohtala opened this issue Apr 11, 2024 · 2 comments

Comments

@kohtala
Copy link

kohtala commented Apr 11, 2024

It seems the action calls cacheDir to save a downloaded and extracted sscache, but it does not use find to see if it is already in the cache and calls directly downloadTool to download it again.

@Xuanwo
Copy link
Collaborator

Xuanwo commented Apr 11, 2024

Oh, you are right. Would you like to give it a fix?

@kohtala
Copy link
Author

kohtala commented Apr 12, 2024

I'd like, but am unable. Best I could do is drop the note of what I noticed.

sylvestre pushed a commit that referenced this issue Jul 18, 2024
* fix: avoid downloading package when local cache exists

As mentioned in
#107,
`setup` function didn't use `find` function even though it uses
`cacheDir` to store downloaded files, which leads to redundant download.

It is not significant on GitHub-hosted runners because
`cacheDir` stores files in local file system, which is ephemeral.
However, it wastes time on self-hosted runners.

This commit adds a step to search local file system cache for sccache as
well as splitting download procedure to a dedicated function.

* fix: explicit comparison for boolean-like value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants