add support for undo and redo to vi KeyMap #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used later. Right now we just properly track the count.
This will repeat the last insert `count` times.
This command repeats the last normal command or the last insert command. It also supports counts.
This is necessary to support proper undoing in insert mode.
This also properly marks the start and end of undo groups in order to properly support undoing and redoing commands with counts and insert commands.
This was referenced Feb 7, 2017
iamcodemaker
commented
Feb 7, 2017
| pub fn current_buffer_mut(&mut self) -> &mut Buffer { | ||
| cur_buf_mut!(self) | ||
| } | ||
|
|
There was a problem hiding this comment.
instead of this method, I could add start_undo_group() and end_undo_group() methods to Editor as this is only used to call those methods on Buffer. Not sure if that is better.
|
Included in #30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for undo and redo to the vi KeyMap. This required adding the concept of an undo group to the Buffer struct.
#6
Depends on #27
Blocks #29