Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radial menu #2721

Merged
merged 5 commits into from
Apr 6, 2017
Merged

Add radial menu #2721

merged 5 commits into from
Apr 6, 2017

Conversation

syntaxi
Copy link

@syntaxi syntaxi commented Dec 31, 2016

Added a new radial menu as per issue #2713.

This needs more testing done on it before it should be merged. An example and documented .ui orefab is here.

Todo:

  • Possibly change to having sections as widgets themselves
  • Add support for sub menus
  • Add support for other stuff to happen on a selection pressed. Ie, a butten press or event fire.

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@rzats rzats added Google Code-in Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience labels Jan 3, 2017
@rzats rzats self-requested a review January 3, 2017 18:00
@GooeyHub
Copy link
Member

GooeyHub commented Jan 6, 2017

Hooray Jenkins reported success with all tests good!

@GooeyHub
Copy link
Member

GooeyHub commented Jan 7, 2017

Hooray Jenkins reported success with all tests good!

Copy link
Member

@Cervator Cervator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got a chance to take this for a spin - but I wonder if UIRadialMenuScreen is missing? It is the type used in the paste example, but not in the PR.

Code could use some javadoc more than anything, eager to put it to use. Some commented out stuff and things still to do, but I can imagine it working!

Submitted Terasology/TutorialNui#3 to get a matching example, that might also be a good way to get the sample code out of a paste and into a working module :-)

mousePos.y -= radius;

logger.info(mousePos.toString());
double angle = Math.atan2(mousePos.y(), mousePos.y()); logger.info(angle + " ang");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have accidentally lost a newline here?

import org.terasology.rendering.assets.texture.TextureRegion;
import org.terasology.rendering.nui.Canvas;

public class UIRadialEmpty extends UIRadialSection {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great with class-level Javadoc on this and similar :-)

 - Remove wedge images
 - Remove empty section class
 - Add circle images
 - Add support for varying number of section
 - Add javadoc
@GooeyHub
Copy link
Member

GooeyHub commented Apr 4, 2017

Hooray Jenkins reported success with all tests good!

@Cervator
Copy link
Member

Cervator commented Apr 5, 2017

Linking to request Terasology/TutorialNui#3 for example sometime :-)

@Cervator Cervator added this to the Alpha 8 milestone Apr 6, 2017
@Cervator Cervator merged commit eb983e0 into MovingBlocks:develop Apr 6, 2017
Cervator added a commit that referenced this pull request Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants