Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SaveManager called from modules crash fix #681

Merged
merged 1 commit into from
Mar 31, 2023
Merged

SaveManager called from modules crash fix #681

merged 1 commit into from
Mar 31, 2023

Conversation

BenjaminAmos
Copy link
Contributor

@BenjaminAmos BenjaminAmos commented Mar 31, 2023 •
edited
Loading

Description

This pull request fixes a crash caused by modules, directly or indirectly, calling SaveManager to save the game.

In the case of the warp crash, the StarPort class was attempting to save the game upon arrival when it triggered the crash.

Testing

  • Clone the warp module with git clone https://github.com/DestinationSol/warp.git modules/warp.
  • Start a new game with the Warp Endeavour ship
  • Try using the ship's ability to tunnel to the nearest planet

Notes

@BenjaminAmos BenjaminAmos merged commit 3d015cf into MovingBlocks:develop Mar 31, 2023
@BenjaminAmos BenjaminAmos deleted the savemanager-crash-fix branch March 31, 2023 18:04
@BenjaminAmos BenjaminAmos mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warp Endeavour ability causes game crash
1 participant
@BenjaminAmos