jQuery version comparison bug: parseFloat does not see 1.10 > 1.4 #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Mottie
added a commit
that referenced
this pull request
Sep 11, 2013
jQuery version comparison bug: parseFloat does not see 1.10 > 1.4
|
Thank again! |
|
My pleasure! 2013/10/11 Rob G [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current way of comparing the jQuery version is buggy because
parseFloat("1.10") == 1.1this disables data attributes for jQuery 1.10 (current stable).I know the problem solves itself for jQuery 2, but it's still a very big issue for the still maintained 1.x branch.
It would also be very appreciated if the fix was backported to the current stable version of tablesorter.
Great plugin BTW! Kudos!