Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers and Data rows not lining up, bottom header row missing #931

Closed
SPlatten opened this issue Jun 3, 2015 · 6 comments
Closed

Headers and Data rows not lining up, bottom header row missing #931

SPlatten opened this issue Jun 3, 2015 · 6 comments

Comments

@SPlatten
Copy link

SPlatten commented Jun 3, 2015

As discussed before this jsfiddle shows the problem I'm experiencing.

http://jsfiddle.net/SimonPlatten/qt1xx7s6/3/

Not all the data rows are shown in this example and they do not line up with the headers, bottom header row is missing.

This is a cut and paste from firebug, so it may not be entirely accurate, but it does show a lot of the issues.

Versions:
jquery.tablesorter.combined.js, v2.22.1, 2015-05-31
jquery.tablesorter.pager.js, v2.22.0, 2015-05-17
widget-scroller.js, v2.22.0, 2015-05-17
Firefox, v38.0.1
Firebug v2.0.10

Comparing the above output with another table that does render correctly I've noticed that there is no 'tablesorter-scroller-footer' div in the document.

@SPlatten
Copy link
Author

SPlatten commented Jun 3, 2015

I fixed the bottom row header now showing, that was my fault, I was rending the table from a data stream received from a socket. I was creating the thead content but not the tfoot.

However the issue with the data row columns not lining up with the headers is still an issue, the fixed columns line up perfectly.

@SPlatten
Copy link
Author

SPlatten commented Jun 3, 2015

Have now fixed the issue with the data rows and column widths being different, in the data table I had a style='width:90%' , removing this resolved the issue. Almost there now, just need to figure out why horizontal scroll bar bar doesn't appear when brower is resized.

@SPlatten
Copy link
Author

SPlatten commented Jun 3, 2015

There are two div wrappers around the tables, both of these get modified with the styles:

display: block;
height: 455px;
left: 8px;
position: absolute;
top: 84px;
width: 1503px;

I'm not sure why this is done as it doesn't seem to do anything except move the table down abit...and removing them from the DOM doesn't nothing except shift the table up a bit.

@Mottie
Copy link
Owner

Mottie commented Jun 3, 2015

Why is tablesorter being initialized on an already rendered HTML?

I mean, the HTML was copied from a table already set up using the filter & scroller widget, and then the widgets are applied to it a second time... if I remove the initialization code, the table looks "better", but you can't interact with it..

@SPlatten
Copy link
Author

SPlatten commented Jun 3, 2015

I think that was just the jsfiddle cut and paste.

There we go...sorry for the confusion:

http://jsfiddle.net/SimonPlatten/qt1xx7s6/7/

I'm progressing slowly with my live version, still haven't got the horizontal scroll bar for the non-fixed columns.

@SPlatten
Copy link
Author

SPlatten commented Jun 3, 2015

Glad to say all issues now resolved and table working correctly. Hold my hand up, assign one one issue most of the problems were my own.

Mottie added a commit that referenced this issue Jun 22, 2015
Bonus fix #932 which maintains scroll position after sort/filter
@Mottie Mottie closed this as completed Jun 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants