Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table height, when initial state is empty table #742

Closed
Ifko opened this issue Oct 9, 2014 · 7 comments
Closed

Table height, when initial state is empty table #742

Ifko opened this issue Oct 9, 2014 · 7 comments

Comments

@Ifko
Copy link

Ifko commented Oct 9, 2014

If table starts with empty state and pager has fixedHeight is set to true, the table is not set to proper height and its height changes on the last page. Is there something what I am doing wrong.
Fiddle for this issue:
http://jsfiddle.net/9Lzo4256/

@Mottie
Copy link
Owner

Mottie commented Oct 9, 2014

Hi @Ifko!

That is a bug! I'll see what I can do to get it fixed in the next update.

@Mottie
Copy link
Owner

Mottie commented Oct 9, 2014

Ok, try this updated demo which is using the pager addon code from the working branch of this repository.

You'll notice that if the table has no rows it's height is slightly different than when one row is added. This is because, in that demo, a default row is 27 pixels in height. When a row is added its height is 30 pixels because the button in the last column expands the default row height.

@Ifko
Copy link
Author

Ifko commented Oct 14, 2014

Hi,

this is off topic and meant for Jurij Zajcev. We use also
fabricjs and are very content with it. We use table and these
plugins because I haven't found any table that I could use as new
element for fabricjs. Do you know some table implementations
with sorting a paging implemented for canvas?

Thank you, Ifko

@Mottie
Copy link
Owner

Mottie commented Oct 14, 2014

If you mean adding canvas elements within the table cells, then one option is to set the cell's data text (data attribute set by the textAttribute option) with the title of the canvas

<td data-text="tiger"><canvas></td>

@Ifko
Copy link
Author

Ifko commented Oct 16, 2014

Hi, where can I download js pager file from the working branch? Do I need more files or only pager?
And when it is planned next update? Thank you for helping me...
Ifko

@Mottie
Copy link
Owner

Mottie commented Oct 16, 2014

  1. Open the branch selector
  2. Choose the working branch
  3. Download ZIP

tablesorter at working

If you're going to use the updated pager script, you might as well use all of the most up-to-date plugin files.

The next update should be soon... I'm trying to fix a few cross-browser issues that have popped up in some fixes I implemented.

@Ifko
Copy link
Author

Ifko commented Oct 17, 2014

Thanx. It works,

ifko

On Donnerstag, 16. Oktober 2014 15:40:23, Rob G wrote:

  1. Open the branch selector
  2. Choose the working branch
  3. Download ZIP

tablesorter at working
https://cloud.githubusercontent.com/assets/136959/4663238/9b5cbff6-5539-11e4-9526-2211361bd3ee.png

If you're going to use the updated pager script, you might as well use all of
the most up-to-date plugin files.

The next update should be soon... I'm trying to fix a few cross-browser issues
that have popped up in some fixes I implemented.


Reply to this email directly or view it on GitHub
#742 (comment).

Bye, ifko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants