Pager & Ember's #each loop generated table

[mkrzempek]

Pager addon isn't work properly with tables with <script> tags before within section (for example generated in Ember's handlebars {{#each}} loop). So data rows are always hidden.

In hideRows function there is missing tags filtering so I change line:
rows = c.$tbodies.eq(0).children(),
to:
rows = c.$tbodies.eq(0).children('tr'),

Please submit this simple fix or give me a reason why it cannot be implemented that way.

[Mottie]

Hi @mkrzempek!

Will a similar fix to the one mentioned for the thead in #479 help?

The script tags within the tbody are likely not associated with the rows after sorting the table, so I'm not sure if it would be best to just remove them? The fix you mentioned may work for the pager, but other widgets may also have an issue.

[mkrzempek]

You're right - removing script tags is some kind of workaround.

But problem is more complex. Removing scripts make this table static (Ember's app loose ability to refresh table content for example when new row is added). So it cause to make many workaraunds to make table to work properly.

[Mottie]

Ok, I don't have a problem with making that change. I just wasn't sure if the script tags were required. I'll make the change and it will soon be available in the working branch.

[mkrzempek]

Thanks a lot. Finally I don't have to make this change every upgrade from bower.

[Mottie]

This change is now available from the master branch in v2.17.2. Thanks for reporting the problem!