Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 chokes on a.length on line 966 of jquery.tablesorter.js #246

Closed
jorisw opened this issue Feb 23, 2013 · 1 comment
Closed

IE8 chokes on a.length on line 966 of jquery.tablesorter.js #246

jorisw opened this issue Feb 23, 2013 · 1 comment
Labels

Comments

@jorisw
Copy link

jorisw commented Feb 23, 2013

On IE8, I get the following error when initializing tablesorter:

'length' is null or not an object (jquery.tablesorter.js:966)

Fixed this myself by changing the line from:

var i, l = a.length, n = mx + d;

... to:

var i, l = (a ? a.length : 0), n = mx + d;

@Mottie
Copy link
Owner

Mottie commented Feb 23, 2013

Thanks for reporting this issue! I don't have the original IE8 to test this code, so I appreciate the help :)

But could you please test this for me, instead of the code change you proposed, would just changing the outer if statement (line 964) produce the same result?

if (mx && a) {

Ahh, nevermind... I'll stick with your suggestion :P

Mottie added a commit that referenced this issue Feb 24, 2013
@Mottie Mottie closed this as completed Feb 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants