Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorter-false not hiding sorting image? #188

Closed
Roland-Megens opened this issue Dec 2, 2012 · 3 comments
Closed

sorter-false not hiding sorting image? #188

Roland-Megens opened this issue Dec 2, 2012 · 3 comments
Labels

Comments

@Roland-Megens
Copy link

Upgrade tablesorter from a version about 7-8 months old, can't remeber version number, but when sorting is disabled for a column, the sorting icon still shows? This used to be different and I liked that.

headers: { 0: { sorter: false } } is how I set it

Demo's also show sorting icons.
http://mottie.github.com/tablesorter/docs/example-options-headers.html

I would love to see the sorting icons to hide, is that possible?

Thx in advance

Roland

@Mottie
Copy link
Owner

Mottie commented Dec 3, 2012

Oops, I think I messed that up when I made the plugin add tablesorter-header back to all header row cells. Add this css until I fix it in the next patch:

.tablesorter .tablesorter-header.sorter-false {
    background-image: url();
}

@Mottie Mottie closed this as completed in 0ac192d Dec 18, 2012
@cautionbug
Copy link

Mottie,
Could you also add a padding override so the right side of non-sorted columns isn't padded with unnecessary white space?

For example, the default theme sets header cells as:

.tablesorter-default .header, .tablesorter-default .tablesorter-header {
    background-position: right center;
    background-repeat: no-repeat;
    padding: 4px 20px 4px 4px;
}

Could you add (EDITED to remove detritus):

.tablesorter .tablesorter-header.sorter-false {
    background-image: url();
    padding: 4px;
}

@Mottie
Copy link
Owner

Mottie commented Dec 19, 2012

Hi @cautionbug!

Yeah that's a good idea!... but I'm not sure where you're getting the .tablesorter-default .header part in the css. That shouldn't be there since it's not targeting the sorter-false class.

I'll have this updated within an hour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants