Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroller widget doesn't scroll on Safari (Mac and iPhone) #1382

Closed
davidjkrause opened this issue Apr 8, 2017 · 3 comments
Closed

Scroller widget doesn't scroll on Safari (Mac and iPhone) #1382

davidjkrause opened this issue Apr 8, 2017 · 3 comments

Comments

@davidjkrause
Copy link

Put together a JSFiddle for a different issue #1376 but I've found that the same example also doesn't scroll horizontally on Safari. It works fine on Chrome on Mac, Linux, and Android devices, and it also scrolls on Firefox.

Example here: https://jsfiddle.net/e1waajt1/1/

Is there something I'm missing that would cause this to not scroll horizontally on Safari?

@TheSin-
Copy link
Collaborator

TheSin- commented Apr 8, 2017

Thanks for reporting this, I'm the resident Safari "debugger" and sadly I don't use scroller at all so I didn't catch this.

Either way I've made a fix here https://jsfiddle.net/e1waajt1/3/ you can see it's just a one line to css and it's to counter bootstrap.css which is messing with max-width on anything with the class of table.

@Mottie has been made aware of it and will likely commit a fix or at least log this as something required for anyone using bootstrap.css

Either way if you add that to your code it should work till we get a perm solution here.

@davidjkrause
Copy link
Author

Adding that CSS fixed it, thanks so much for the quick suggestion.

@Mottie
Copy link
Owner

Mottie commented Apr 8, 2017

Thanks @TheSin-!

I wonder if that fix also needs to be included for Bootstrap v4?

I think the easiest solution would be to add that css definition to the scroller widget. I tested the demo in the other up-to-date browsers and it works fine.


In case jsFiddle has problems, the fix is:

.tablesorter-scroller-table table.tablesorter {
	max-width: initial;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants