Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Widget and Math Widget #1071

Closed
glend1 opened this issue Nov 4, 2015 · 4 comments
Closed

Filter Widget and Math Widget #1071

glend1 opened this issue Nov 4, 2015 · 4 comments

Comments

@glend1
Copy link

glend1 commented Nov 4, 2015

I am currently using 2.18, with the filter widget installed when I tried to include math functionality I noticed that my external search wasn't working correctly, using the following method;

$('table').trigger('search', [ columns ]);

so I decided to upgrade my version of tablesorter but encountered a bug, report here:

#1070

so i cannot continue and I was wondering if there were any issues with the latest version of tablesorter has any compatibility issues between Filter & Math.

I was also wondering what the third argument in this snippet of code was for, the boolean;

$.tablesorter.setFilters( $('#table'), filters, true );

side issue: the documentation for http://mottie.github.io/tablesorter/docs/example-widget-filter.html is wrong. Tablesorter isn't up to version 2.9 yet, 2.4 is the latest version.

@Mottie
Copy link
Owner

Mottie commented Nov 4, 2015

Hi @doveyg!

I haven't noticed any issues with the filter + math widget... try out the main math widget demo - it works perfectly for me. If you are having an issue, after I provide a fix for #1070, then please provide a demo of the issue you're having.

The third argument of setFilters will apply the search to the table. If false the inputs will get updated, but the actual search won't be applied... in case you want to add rows, or something.

@Mottie
Copy link
Owner

Mottie commented Nov 5, 2015

Also, I don't understand what you meant by:

Tablesorter isn't up to version 2.9 yet, 2.4 is the latest version.

This fork of tablesorter is currently at v2.24.2.

In this next update, I'll make it so that last parameter defaults to true, so you can do this:

// set filters AND apply (the last parameter "apply" is now true by default)
$.tablesorter.setFilters( $('#table'), filters );

@glend1
Copy link
Author

glend1 commented Nov 5, 2015

Sorry, my bad. your right about the versions.

@glend1
Copy link
Author

glend1 commented Nov 9, 2015

Updated and everything seems to be fine. Thank you!

@glend1 glend1 closed this as completed Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants