-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial Load feature #177
Partial Load feature #177
Conversation
This patch add dropdown button for partial loading * Load Djeeta (Player tab) * Load Summon * Load Chara * Load Weapon This change makes users manages their save data as Preset. e.g. Load earth-katana party + Load earth-magna2 weapons. Save data will become more re-usable. ---- This feature is now experimental. The partial loading may break user's save data, If user had clicked the load button by mistake, but there is no Revert. Please save a backup, then try at your own risk.
I will withdraw this PR. The concept was duplicated with #201 and it's better approach.
I was going to tell this in #201, add UI code in current code base increase the legacy code.
There are no E2E tests now, test manually is hard to do. I will still keep this PR until #201 close. (for discussion if someone had ideas) I will show #201 contains the most of this PR aimed then this PR will be unnecessary. このPRは撤回予定です。理由は主に3つ、実装してみてわかった事。(要約)
議論の為に #201 が閉じるまで残しますが、 |
Other comparison #177 and #201
EDIT: fix PR number 171 -> 177 |
I will restart this topic in #201 soon, close here. |
This patch add dropdown button for partial loading
This change makes users manages their save data as Preset.
e.g. Load earth-katana party + Load earth-magna2 weapons.
Save data will become more re-usable.
TODO
simulator
This is an experimental feature, yet
The partial loading may break user's save data,
If user had clicked the load button by mistake, but there is no Revert.
Please save a backup, then try at your own risk.