feature/delegation #132
feature/delegation #132
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| </script> | ||
|
|
||
| <style scoped lang="scss"> | ||
| .table-sorting-header-column { |
There was a problem hiding this comment.
Why column if it is in fact a row?
There was a problem hiding this comment.
Component name is rather too long. Also word Column doesn't really make sense to me, table header is generally a row.
I'd rather make it just TableHeader with optional sorting
| @@ -0,0 +1,13 @@ | |||
| <template> | |||
| <div class="delegation"> | |||
There was a problem hiding this comment.
since it is page a component, let's make it more semantic: <div> --> <main>
unless everything is wrapped with <main> in app layout
Also if app follows classes naming convention based on the component name - I guess it should be delegation-page
| import { bus, BUS_EVENTS, ErrorHandler, getEthExplorerTxUrl } from '@/helpers' | ||
| import { DELEGATION_RIGHTS } from '@/enums' | ||
|
|
||
| const MIN_DELEGATION_AMOUNT = 0.000001 |
There was a problem hiding this comment.
form fields validation consts is better to store in one place in case you'll ever need to reuse them.
example:
export const FIELD_LENGTH = {
contractName: {
min: 3,
max: 64,
},
addressList: {
min: 1,
max: Number.MAX_SAFE_INTEGER,
},
setName: {
min: 1,
max: 100,
},
description: {
min: 0,
max: 300,
},
} as const
export const FIELD_VALUE = {
tokenThreshold: {
min: 1,
default: 50_000,
max: Number.MAX_SAFE_INTEGER,
},
} as const| @mouseenter="showDelegateButton" | ||
| @mouseleave="hideDelegateButton" |
There was a problem hiding this comment.
Is your app supposed to work on touch screen devices?
If yes - everything that happens here on mouse events won't work on those devices
| const isDelegateModalShown = ref(false) | ||
|
|
||
| const username = computed(() => MOCKED_USERNAMES[props.user.address] ?? '') | ||
| const isYou = computed(() => props.user.address === web3ProvidersStore.address) |
There was a problem hiding this comment.
isYou --> isConnectedWallet
| @@ -0,0 +1,130 @@ | |||
| <template> | |||
| <div class="delegation-providers-list"> | |||
There was a problem hiding this comment.
if it is a list and it looks like list it's better to use semantically matching html elements (<ul>, <ol>, <li>)
| @@ -0,0 +1,46 @@ | |||
| <template> | |||
| <div class="delegator-info-page"> | |||
There was a problem hiding this comment.
same as above
<div> --> <main>
| const { t } = useI18n() | ||
| const route = useRoute() | ||
| const web3ProvidersStore = useWeb3ProvidersStore() | ||
| const isYou = computed( |
There was a problem hiding this comment.
isYou --> isConnectedWallet
No description provided.