forked from themeetgroup/lottie-ios
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Include animation duration when computing cost/complexity of Core Ani…
…mation time remapping (airbnb#2381)
- Loading branch information
Showing
15 changed files
with
24 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
3 changes: 2 additions & 1 deletion
3
Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-issue_1403.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
Supports Core Animation engine | ||
Does not support Core Animation engine. Encountered compatibility issues: | ||
[root layer] This animation has a very large number of layers with time remapping (289 layers over 360 frames) so will perform poorly with the Core Animation rendering engine. |
2 changes: 2 additions & 0 deletions
2
Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-issue_2330.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Does not support Core Animation engine. Encountered compatibility issues: | ||
[root layer] This animation has a very large number of layers with time remapping (406 layers over 193 frames) so will perform poorly with the Core Animation rendering engine. |
2 changes: 1 addition & 1 deletion
2
Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-pr_2286.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
Does not support Core Animation engine. Encountered compatibility issues: | ||
[root layer] This animation has a very large number of layers with time remapping (3670), so will perform poorly with the Core Animation rendering engine. | ||
[root layer] This animation has a very large number of layers with time remapping (3670 layers over 1001 frames) so will perform poorly with the Core Animation rendering engine. |
Binary file added
BIN
+70.8 KB
...pshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2330-0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+71.1 KB
...hots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2330-100.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+80.8 KB
...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2330-25.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+76 KB
...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2330-50.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+43.9 KB
...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2330-75.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+70.8 KB
...Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2330-0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+71 KB
...apshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2330-100.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+80.8 KB
...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2330-25.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+75.8 KB
...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2330-50.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+43.9 KB
...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2330-75.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.