Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add armv7h builds #723

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Add armv7h builds #723

merged 1 commit into from
Apr 12, 2022

Conversation

jclds139
Copy link
Contributor

Adds arm7 builds to the workflows, closing #83

Since ALARM no longer supports arm or armv6h, this should be the only arm binary still necessary.

Combines:

fixup! Correct armv7 arch naming
fixup! lopsided/archlinux arch name for armv7h
fixup! Dockerfile tmpfs workaround arm32 on amd64

Adds a workaround mounting the .cargo directory as a tmpfs to avoid
https://gitlab.com/qemu-project/qemu/-/issues/263
@Morganamilo
Copy link
Owner

I don't really get this as, you're adding armv7 to the matrix but then also adding armv7 specific steps to the workflow. You also tweak the dockerfile a bit and am not quite sure why.

@Morganamilo
Copy link
Owner

Wait scratch that. It's been a while and I didn't realise how much of the CI was duplicated already.

Still not sure what the Dockerfile change is for though.

@Morganamilo
Copy link
Owner

And scratch that again, Didn't realise explanation was in the commit message just not the PR message. This looks like it could be really good then.

@Morganamilo
Copy link
Owner

Works. Thanks for finding the fix.

@Morganamilo Morganamilo merged commit c11a2e1 into Morganamilo:master Apr 12, 2022
@Morganamilo
Copy link
Owner

Build seems to be broken' any idea what's up?

@jclds139
Copy link
Contributor Author

jclds139 commented Jun 27, 2022 via email

@Morganamilo
Copy link
Owner

I actually figured it out to be cargo downloading the index filling memory and getting killed by oom. Not sure what caused this change as it's the same error rerunning the .10 release.

Fixed with a nightly flag for now.

@jclds139
Copy link
Contributor Author

jclds139 commented Jun 27, 2022 via email

@Morganamilo
Copy link
Owner

It may be due to some change in cargo but I don't really want to bisect it. If i do bisect it, it just means Paru will have to build on an old rust version in CI. A version that paru may no longer support. The nightly flag will do for now.

@jclds139
Copy link
Contributor Author

jclds139 commented Jun 27, 2022 via email

@Morganamilo
Copy link
Owner

You'd think but it still broke when I reverted that.

@jclds139
Copy link
Contributor Author

It looks like this is a known issue with cargo: rust-lang/cargo#10583, and possibly the fault of libgit2/libgit2. Conveniently, libgit2 is also the culprit for the size mismatch on 32bit platforms. We can bypass it by exporting CARGO_NET_GIT_FETCH_WITH_CLI=true before running cargo as long as git is installed in the build container.

@olof-nord olof-nord mentioned this pull request Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants