-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow more options to be configured in paru.conf and command line arguments #603
Conversation
The goal of the provided config is to be an example and highlight some options that may be useful. Not everything is meant to be listed there. Comments is a flag and doesn't really make sense as a config option. makepkgconf is good to add though. It also appears to be missing from the man page. Pager is probably fine though. It may be useful for if paru is called from some non shell script where you can't prefix env vars. |
I'll admit I definitley went overboard on the default config, but what options would you say should stay there? I was thinking of removing most of the I'll also add makepkgconf to the man page in a commit soon; i'm just a bit busy with finals |
The config should stay as is. There's a man page that lists all the options and people should read that. |
...I think I just accidentally pushed a horrible branch. Going to fix now |
Sorry about that, should be good now. |
fixed |
This pull request allows for more internal configuration options (namely
config.comments
,config.makepkg_conf
, andconfig.pager
) to be changed in the configuration file and passed as command line arguments. I updated the shell completions and the defualtparu.conf
to reflect the changes as well.I only added cli arguments that I found to be a configuration option in
src/config.rs
but not insrc/command_line.rs
. I did something similar with the configuration file options by adding configuration options that were avalible but not present in theparse_*()
functions ofsrc/config.rs
. I checked a few times to make sure I got them all, ignoring some options I believed shouldn't be included...but I wouldn't be surprised if I missed some