Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow more options to be configured in paru.conf and command line arguments #603

Merged
merged 9 commits into from
Dec 13, 2021
Merged

allow more options to be configured in paru.conf and command line arguments #603

merged 9 commits into from
Dec 13, 2021

Conversation

getchoo
Copy link
Contributor

@getchoo getchoo commented Nov 30, 2021

This pull request allows for more internal configuration options (namely config.comments, config.makepkg_conf, and config.pager) to be changed in the configuration file and passed as command line arguments. I updated the shell completions and the defualt paru.conf to reflect the changes as well.

I only added cli arguments that I found to be a configuration option in src/config.rs but not in src/command_line.rs. I did something similar with the configuration file options by adding configuration options that were avalible but not present in the parse_*() functions of src/config.rs. I checked a few times to make sure I got them all, ignoring some options I believed shouldn't be included

...but I wouldn't be surprised if I missed some

@Morganamilo
Copy link
Owner

The goal of the provided config is to be an example and highlight some options that may be useful. Not everything is meant to be listed there.

Comments is a flag and doesn't really make sense as a config option.

makepkgconf is good to add though. It also appears to be missing from the man page.

Pager is probably fine though. It may be useful for if paru is called from some non shell script where you can't prefix env vars.

@getchoo
Copy link
Contributor Author

getchoo commented Dec 4, 2021

I'll admit I definitley went overboard on the default config, but what options would you say should stay there? I was thinking of removing most of the *flags options, but keeping some like PreBuildCommand, MakepkgConf, Pager, Redownload, and NoCheck - since they would be likely used by at least some people (or at least by me with MakepkgConf for chroot builds).

I'll also add makepkgconf to the man page in a commit soon; i'm just a bit busy with finals

@Morganamilo
Copy link
Owner

The config should stay as is. There's a man page that lists all the options and people should read that.

@getchoo
Copy link
Contributor Author

getchoo commented Dec 7, 2021

...I think I just accidentally pushed a horrible branch. Going to fix now

@getchoo
Copy link
Contributor Author

getchoo commented Dec 7, 2021

Sorry about that, should be good now.

man/paru.8 Outdated Show resolved Hide resolved
@getchoo
Copy link
Contributor Author

getchoo commented Dec 9, 2021

fixed

@Morganamilo Morganamilo merged commit 10ae8ee into Morganamilo:master Dec 13, 2021
@getchoo getchoo deleted the add-more-options branch December 14, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants